Peak calling to dev #38
Merged
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev to my branch
…bed file. the point will be printed to the last column in the output bed file
…eating one if it does not exist
|
Because it is convenient in bed files to use . if there is no information provided. |
HendrikSchultheis
approved these changes
Jan 4, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just fixed the problem, Jannik had with my output files. His script needs a file that has exactly n-number of columns. As I have not written the columns with bonus info if it was not provided by the original bed file given as input, the script of Jannik could not parse my output file. To make life easier for Jannik, I have just added some small changes, to always have the same number of columns in the output bed file, even if i have no bonus_info from the original bed file. In such a case the last column called bonus_info (as usually) will contain only "."
Also I check for the output directory user could provide as a path to save the output bed file. Just to be sure there are no problems with that.